comaniac commented on a change in pull request #7350:
URL: https://github.com/apache/tvm/pull/7350#discussion_r576349262
##########
File path: python/tvm/contrib/target/vitis_ai.py
##########
@@ -132,12 +132,12 @@ def vitis_ai_compiler(ref):
layers = xgraph.get_layers()
# Get the output tensor names using XGraph and output Relay ids
- out_tensor_names = []
+ out_tensor_names = ["unknown_name"] * len(output_relay_ids)
for layer in layers:
if not layer.internal:
for relay_id in layer.attrs["relay_id"]:
if relay_id in output_relay_ids:
- out_tensor_names.append(layer.name)
+ out_tensor_names[output_relay_ids.index(relay_id)] =
layer.name
break
if not out_tensor_names:
Review comment:
```suggestion
if any([name == "unkown_name" for name in out_tensor_names]):
```
With the change in L135, this condition would never be triggered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
