tkonolige commented on a change in pull request #7472:
URL: https://github.com/apache/tvm/pull/7472#discussion_r580555684
##########
File path: src/runtime/rocm/rocm_device_api.cc
##########
@@ -200,5 +200,28 @@ TVM_REGISTER_GLOBAL("device_api.rocm").set_body([](TVMArgs
args, TVMRetValue* rv
DeviceAPI* ptr = ROCMDeviceAPI::Global();
*rv = static_cast<void*>(ptr);
});
+
+TVM_REGISTER_GLOBAL("profiling.timer.rocm").set_body_typed([](TVMContext ctx) {
+ hipEvent_t start;
Review comment:
The assumption here is that each function is called only once. If that
constraint is violated, then its possible to double free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
