areusch commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r581356381
##########
File path: src/runtime/c_runtime_api.cc
##########
@@ -474,7 +474,8 @@ int TVMFuncCreateFromCFunc(TVMPackedCFunc func, void*
resource_handle, TVMPacked
int ret = func(const_cast<TVMValue*>(args.values),
const_cast<int*>(args.type_codes),
args.num_args, rv, resource_handle);
if (ret != 0) {
- throw dmlc::Error(TVMGetLastError() + ::dmlc::StackTrace());
+ throw tvm::Error(TVMGetLastError() +
+ tvm::runtime::Backtrace()); // TODO(tkonolige): this
may double backtrace
Review comment:
can you comment this in? why would it already contain a
backtrace--because this function was previously called down-stack?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
