rkimball commented on a change in pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#discussion_r582139400
##########
File path: python/tvm/contrib/cc.py
##########
@@ -212,9 +214,9 @@ def _linux_compile(output, objects, options,
compile_cmd="g++", compile_shared=F
raise RuntimeError(msg)
-def _windows_shared(output, objects, options):
+def _windows_compile(output, objects, options):
cmd = ["clang"]
- cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"]
+ cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"]
Review comment:
The current code in the PR only has the flag `-O2`. The other flags are
not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
