comaniac commented on pull request #7564: URL: https://github.com/apache/tvm/pull/7564#issuecomment-789145492
> I noticed that there is a check implemented for demanding codegen_name to be placed first ([utils.h](https://github.com/apache/tvm/blob/633ee118efecd04efb4be9bf6053deae6e8fac3b/src/relay/backend/utils.h#L89)) in case of external codegen uses its own implementation of ConstUpdater. Looks to me now that I am on a safe side with current patch Yeha that's why I asked the question about if `codegen_name` and `symbol` always the same, but it doesn't solve the problem that even a parameter is named with the external codegen prefix, it's still possible that the external module doesn't maintain it. btw, if the purpose of this PR is going to solve this issue (https://discuss.tvm.apache.org/t/model-graph-size-doubling-after-partitioning-for-arm-compute-library/9131), I think it would be much easier to add an ACL constant updater like what Ethos-N does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
