apivovarov commented on a change in pull request #7605:
URL: https://github.com/apache/tvm/pull/7605#discussion_r589717449
##########
File path: src/runtime/vm/executable.cc
##########
@@ -525,12 +521,10 @@ void Executable::LoadConstantSection(dmlc::Stream* strm) {
}
Review comment:
Here we use `uint64_t` to read `number of constants` from the Stream.
After that we read all constants from the Stream one after another.
`constants` vector size can not be bigger that `size_t` on a particular
platform.
It is ok to use `size_t` for looping purpose (`size_t` is not written or
read to/from the Stream).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
