masahi commented on a change in pull request #7611:
URL: https://github.com/apache/tvm/pull/7611#discussion_r589828485
##########
File path: src/tir/transforms/storage_access.cc
##########
@@ -132,6 +132,7 @@ void StorageAccessVisitor::VisitStmt_(const AttrStmtNode*
op) {
StmtExprVisitor::VisitStmt_(op);
}
env_threads_.pop_back();
+ } else if (op->attr_key == attr::hand_threaded) {
} else {
Review comment:
How about this?
```
else if (op->attr_key != attr::hand_threaded) {
StmtExprVisitor::VisitStmt_(op);
}
```
And better to leave a comment on what's up with `attr::hand_threaded`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
