zxybazh commented on pull request #7534: URL: https://github.com/apache/tvm/pull/7534#issuecomment-793281419
> In general my opinion is of course we should maintain back compatible as possible, but we should not keep the non-effective argument (i.e., `target_host`). In short, `target_host` should not become an unused-argument anywhere after this PR. Since this warning has been disabled in TVM pylintrc, manual check should be done for this case. > > For API updating, I'd suggest either of the following approaches (can be applied case by case): > > 1. Simply remove the `target_host` argument if that API is seldemly used. > 2. Keep the `target_host` argument, but log out a warning saying this is not effective anymore and will be deprecated. Thanks Cody for the advice. Of course, if you spot any unused `target_host` hanging out there and we should simply remove that. For simplicity we should definitely remove `target_host` and replace it with `target.host` in most occurance. I did not remove all of them mainly because of two reasons: 1. For heterogeneous targets, there could be multiple targets maintained in a dict, which makes a single target_host more convenient in related context. 2. It takes more time to replace all the occurance, and part of the code would be refactored, e.g., the structure of `SearchTaskNode` and the signature of `target_host` related functions, once we decide to deprecate `target_host`. I want to leave the work later if we decide on deprecation and be more consistent in design at that time. For API updating, both would be good choice. I would post two of them onto the [RFC](https://discuss.tvm.apache.org/t/rfc-tvm-target-specification/6844/56) and see what others think and decide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
