junrushao1994 commented on a change in pull request #7647:
URL: https://github.com/apache/tvm/pull/7647#discussion_r592919396
##########
File path: tests/python/relay/test_type_infer.py
##########
@@ -416,6 +416,21 @@ def test_dynamic_function():
assert mod["main"].params[0].checked_type == s_tt
[email protected](raises=tvm.error.TVMError)
Review comment:
let's use `with pytest.raises` instead
(https://docs.pytest.org/en/stable/assert.html#assertions-about-expected-exceptions),
because the testcase tests for throwing an exception, not a known limitation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
