huajsj commented on a change in pull request #7619:
URL: https://github.com/apache/tvm/pull/7619#discussion_r593322682
##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -155,6 +166,25 @@ class BuiltinLower : public StmtExprMutator {
return StmtExprMutator::VisitExpr_(op);
}
}
+ std::string GetUniqueName(std::string prefix) {
+ for (size_t i = 0; i < prefix.size(); ++i) {
+ if (prefix[i] == '.') prefix[i] = '_';
+ }
Review comment:
@zhuwenxi, thanks for the clarify, the idea make GetUniqueName to a
utility function is a great, I also understand this code style is existing
issue, either keep it on this patch or make a utility function and fix is ok to
me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
