leandron commented on a change in pull request #7651:
URL: https://github.com/apache/tvm/pull/7651#discussion_r593362401



##########
File path: tests/python/driver/tvmc/test_tvmc_common.py
##########
@@ -273,3 +273,24 @@ def test_parse_multiple_target_with_opts():
     assert "myopt" in targets[0]["opts"]
     assert "value" == targets[0]["opts"]["myopt"]
     assert "llvm" == targets[1]["name"]
+
+
+def test_parse_multiple_separators_on_target():

Review comment:
       I merged them into a single test, which I called 
`test_parse_quotes_and_separators_on_options`, but I think the error in case it 
fails, is more helpful if we just leave the default "expecting X but got Y 
instead", sort of message.
   
   Example:
   ```
   >       assert "+v1.0x,+value" == targets[0]["opts"]["option1"]
   E       assert '+v1.0x,+value' == "'+v1.0x,+value'"
   E         - '+v1.0x,+value'
   E         ? -             -
   E         + +v1.0x,+value
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to