leandron commented on a change in pull request #7658:
URL: https://github.com/apache/tvm/pull/7658#discussion_r594205774
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -196,9 +196,9 @@ def compile_model(
for codegen_from_cli in extra_targets:
codegen =
composite_target.get_codegen_by_target(codegen_from_cli["name"])
partition_function = codegen["pass_pipeline"]
- mod = partition_function(mod, params)
+ mod, codegen_config = partition_function(mod, params)
Review comment:
In the interest of standardizing all the `partition_for_*` functions, I
think it would be good to do a little refactoring in the
`partition_for_tensorrt` so that it only returns `mod`. This is important not
only for TVMC, but I think it would be a good move in terms of future
partitioning support in TVM.
There is some new functionality (yet to be merged) in #7577 to have an
`init` function per target in tvmc, in which we can then populate the configs
using the existing `get_tensorrt_version`.
I suggest we coordinate to get #7577 landed and then adjust this to comply
with the suggestions above, so that we can get a uniform support for all
targets. What do you think?
(cc @comaniac)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
