[GitHub] [tvm] zhuwenxi commented on pull request #7619: [BugFix] Fix the race condition issue of packed func. (#7246).

[GitBox]

zhuwenxi commented on pull request #7619:
URL: https://github.com/apache/tvm/pull/7619#issuecomment-801573912


   @tqchen Thanks for the explanation. Actually, there are two separate 
allocations in my fix, indeed:
   1. The original code logic in "lower_tvm_builtin.cc" is revered in my 
proposal, a shared stack is allocated for packed_call2:
   
![image](https://user-images.githubusercontent.com/4969797/111565189-ee41b700-87d5-11eb-9f97-d190cd6d57da.png)
   
   2. The override version of "VisitStmt_(const ForNode *op)" is added to 
lower_tvm_builtin.cc, to handle the stack (re)allocation of packed_call1:
   
![image](https://user-images.githubusercontent.com/4969797/111565378-3234bc00-87d6-11eb-9535-5b46475db973.png)
   
   So I don't see any problem in my proposal, for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org