jwfromm opened a new pull request #7699:
URL: https://github.com/apache/tvm/pull/7699


   There was recently some discussion about how the onnx importer should handle 
being passed a shape dict that contains inputs not found in the onnx graph. 
Currently, the importer will just ignore these inputs. However, this could lead 
to user confusion if they make a simple typo and are expecting different 
behavior than what they get. This PR adds checking for inputs in the shape dict 
that arent part of the graph and informs the user if it finds any. Overall, 
this should provide a more clear experience.
   
   I added a test to confirm the behavior works as described and found that one 
of our onnx tests (test_pad) was actually providing gratuitous input 
information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to