tqchen edited a comment on pull request #7630: URL: https://github.com/apache/tvm/pull/7630#issuecomment-802925883
Seems that @Hzfengsy has made the further update on the actionable comments: - adding clarifications to enter_block_scope and enter_scope per @tkonolige 's suggestion - clarified the fields per @jroesch 's suggestion Note these are changes to clarify the general internal functions. The current internal docs are reasonable(of course not perfect), and the clarity matches what we already have in the codebase, e.g. [parser.cc](https://github.com/apache/tvm/blob/main/src/parser/parser.cc). Additionally, significant amount of efforts of this PR are spent better on error reporting, adding type anotations. These are a significant improvements over the current TVMScript parser. We can also make further improvements in the followup PRs. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
