altanh commented on pull request #7731:
URL: https://github.com/apache/tvm/pull/7731#issuecomment-807105375


   > @altanh I'm confused why you need this change to ToScalar. What changed 
elsewhere in your PR that broke this unit test?
   
   here's the offending test 
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7731/7/pipeline
   
   the alternative I see to changing `ToScalar` is basically just mirroring the 
code exactly but instead returning a bool if there is a way to convert, which 
seems less sustainable but perhaps better in the name of API stability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to