zhuwenxi commented on a change in pull request #7619:
URL: https://github.com/apache/tvm/pull/7619#discussion_r603074708
##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -140,6 +164,23 @@ class BuiltinLower : public StmtExprMutator {
return StmtExprMutator::VisitStmt_(op);
}
}
+ Stmt VisitStmt_(const ForNode* op) final {
+ PrimExpr min = this->VisitExpr(op->min);
+ PrimExpr extent = this->VisitExpr(op->extent);
+ Stmt body;
+
+ if (op->kind == ForKind::kParallel) {
+ body = this->RealizeAlloca(op->body);
+ } else {
+ body = this->VisitStmt(op->body);
+ }
+ auto n = CopyOnWrite(op);
Review comment:
Done.
##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -140,6 +164,23 @@ class BuiltinLower : public StmtExprMutator {
return StmtExprMutator::VisitStmt_(op);
}
}
+ Stmt VisitStmt_(const ForNode* op) final {
+ PrimExpr min = this->VisitExpr(op->min);
+ PrimExpr extent = this->VisitExpr(op->extent);
+ Stmt body;
+
+ if (op->kind == ForKind::kParallel) {
+ body = this->RealizeAlloca(op->body);
+ } else {
+ body = this->VisitStmt(op->body);
+ }
+ auto n = CopyOnWrite(op);
+ n->min = std::move(min);
+ n->extent = std::move(extent);
+ n->body = std::move(body);
+ Stmt stmt(n);
Review comment:
Done.
##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -158,64 +199,67 @@ class BuiltinLower : public StmtExprMutator {
// call shape
PrimExpr MakeShape(const CallNode* op) {
// if args.size() == 0, it represents a scalar shape ()
- if (run_shape_stack_ == -1) {
- run_shape_stack_ = 0;
+ auto& scope = alloca_scope_.back();
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
