tmoreau89 commented on a change in pull request #7747:
URL: https://github.com/apache/tvm/pull/7747#discussion_r603638068
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -3200,7 +3272,7 @@ def from_onnx(model, shape=None, dtype="float32",
opset=None, freeze_params=Fals
# try use onnx's own model checker before converting any model
try:
onnx.checker.check_model(model)
- except onnx.onnx_cpp2py_export.checker.ValidationError as e: #
pylint: disable=c-extension-no-member
+ except Exception as e: # pylint: disable=c-extension-no-member,
broad-except
Review comment:
Agreed, large models may fail the check but can still run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]