areusch commented on a change in pull request #7804: URL: https://github.com/apache/tvm/pull/7804#discussion_r609848776
########## File path: apps/microtvm/zephyr/demo_runtime/boards/qemu_riscv32.conf ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# This file is specific to the QEMU-emulated RISCV32 microTVM board. + +# For TVMPlatformGenerateRandom(). Remember, these values do not need to be truly random. +CONFIG_TEST_RANDOM_GENERATOR=y +CONFIG_TIMER_RANDOM_GENERATOR=y + +# Default 512, for operations with large floating point data. Review comment: could you clarify this to "default is 512, raised here for operations with large floating point data." ########## File path: tests/micro/zephyr/test_zephyr.py ########## @@ -59,7 +66,7 @@ def _make_sess_from_op(model, zephyr_board, west_cmd, op_name, sched, arg_bufs): def _make_session(model, target, zephyr_board, west_cmd, mod): - test_name = f"{os.path.splitext(os.path.abspath(__file__))[0]}_{model}" + test_name = f"{os.path.splitext(os.path.abspath(__file__))[0]}_{zephyr_board}" Review comment: why this change? seems like we should put both in the path, if anything ########## File path: apps/microtvm/reference-vm/base-box-tool.py ########## @@ -358,14 +358,18 @@ def test_command(args): def release_command(args): + vm_name = f"mehrdadh/microtvm-{args.platform}" + if args.platform == "zephyr": + vm_name = f"{vm_name}-{args.zephyr_version}" Review comment: I think it would be better to not by default publish any version, but instead require that the user explicitly state it. otherwise, we'll wind up publishing lots of zephyr-2.5 boxes :) also--we could probably call this platform-version, since `tlcpack/microtvm-<platform>-<platform_version>` is a pretty generic format we'll keep if we add more platforms -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
