tqchen edited a comment on pull request #7717: URL: https://github.com/apache/tvm/pull/7717#issuecomment-817316477
Thanks @masahi for great discussions. It seems to me that we want a bit more time reviewing and discussing the PR. Given it is already merged, we could consider: - A0: Revert the PR, and bring another one, do another round of thorough reviews there. - A1: Bring a fix PR as soon as possible. To summarize the items that needs to be addressed: - P0: Add the use of UBO as meta-data to shader, so we won't have compiler runtime in-consistentcy problem - P1: Solve the deferred execution case when a UBO buffer can be overriden by the followup kernel calls(need to do the copy in deferred stream as well). - P2: Solve the multi-thread safety issue when multiple threads calls into UBO at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
