hogepodge commented on a change in pull request #7840: URL: https://github.com/apache/tvm/pull/7840#discussion_r612785488
########## File path: docs/README.txt ########## @@ -3,7 +3,7 @@ TVM Documentations This folder contains the source of TVM documents - A hosted version of doc is at https://tvm.apache.org/docs -- pip install sphinx>=1.5.5 sphinx-gallery sphinx_rtd_theme matplotlib Image recommonmark "Pillow<7" autodocsumm tlcpack-sphinx-addon +- pip install "sphinx>=1.5.5" sphinx-gallery sphinx_rtd_theme matplotlib Image recommonmark "Pillow<7" "autodocsumm<0.2.0" tlcpack-sphinx-addon Review comment: My only comment is a small one. When we pin, we need to document why, and under what conditions we can un-pin. I can't speak to sphinx or Pillow, but we should link to this and note we can remove the pin when the change is in upstream packages. https://github.com/Chilipp/autodocsumm/pull/42#issuecomment-818243851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
