jwfromm commented on a change in pull request #7823:
URL: https://github.com/apache/tvm/pull/7823#discussion_r613443519
##########
File path: python/tvm/driver/tvmc/runner.py
##########
@@ -112,8 +112,10 @@ def drive_run(args):
except IOError as ex:
raise TVMCException("Error loading inputs file: %s" % ex)
- outputs, times = run_module(
- args.FILE,
+ tvmc_package = TVMCPackage(package_path=args.FILE)
Review comment:
You're right that this change means that packages created by tvmc before
this PR will no longer be usable. After talking to @areusch, I'm of the
understanding that the plan is to standardize model packaging using
`export_model_library_format` across TVM soon, so I think this is a pain point
that will have to be introduced into TVMC eventually. I thought it made sense
to bite the bullet now rather than later. However, it would be pretty
straight-forward to convert a legacy package to the new format. I'd be happy to
provide a helper script that does that if you'd like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
