electriclilies commented on a change in pull request #7860:
URL: https://github.com/apache/tvm/pull/7860#discussion_r614377652
##########
File path: src/relay/op/nn/pad.cc
##########
@@ -114,7 +114,7 @@ Array<Array<Layout>> PadInferCorrectLayout(const Attrs&
attrs, const Array<Layou
bool PadRel(const Array<Type>& types, int num_inputs, const Attrs& attrs,
const TypeReporter& reporter) {
- ICHECK_EQ(types.size(), 2);
Review comment:
Could you add a comment saying what is in the types array while you're
making these changes? Something like
`// types = [pad_width_type, pad_value_type, ret_type]` (some of the type
rels have these annotations and I find them helpful)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
