areusch commented on a change in pull request #7838:
URL: https://github.com/apache/tvm/pull/7838#discussion_r614962798
##########
File path: src/runtime/crt/host/main.cc
##########
@@ -136,9 +136,12 @@ int main(int argc, char** argv) {
"failed to register GraphExecutor TVMModule");
#endif
- if (TVMFuncRegisterGlobal("tvm.testing.reset_server",
(TVMFunctionHandle)&testonly_reset_server,
- 0)) {
- fprintf(stderr, "utvm runtime: internal error registering global
packedfunc; exiting\n");
+ int error = TVMFuncRegisterGlobal("tvm.testing.reset_server",
+ (TVMFunctionHandle)&testonly_reset_server,
0);
+ if (error) {
+ fprintf(stderr,
+ "utvm runtime: internal error (error#: %d) registering global
packedfunc; exiting\n",
Review comment:
thanks for fixing this, could I suggest we print with %x since it will
make it easier to lookup the error code?
##########
File path: src/runtime/rpc/rpc_endpoint.cc
##########
@@ -1042,12 +1069,38 @@ class RPCClientSession : public RPCSession, public
DeviceAPI {
bool IsLocalSession() const final { return false; }
private:
+ void RPCMaxTransferRemoteReturnValue(TVMArgs args) {
+ // Use args[1] as return value, args[0] is tcode
Review comment:
nit: could also cite unpack logic in RPCWrappedFunc in
src/runtime/rpc/rpc_module.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
