areusch commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r615011186
##########
File path: src/target/source/codegen_c_host.cc
##########
@@ -40,13 +40,16 @@ namespace codegen {
CodeGenCHost::CodeGenCHost() { module_name_ =
GetUniqueName("__tvm_module_ctx"); }
-void CodeGenCHost::Init(bool output_ssa, bool emit_asserts, std::string
target_str) {
+void CodeGenCHost::Init(bool output_ssa, bool emit_asserts, bool
is_aot_executor,
+ std::string target_str) {
Review comment:
@giuseros I just realized I forgot one other point:
- do we need to have aot_backend_api.c now? it would be great to unify with
crt_backend_api.cc, and simply not pass `--system-lib` for now with AOT
runtime.
It seems like we may be able to get away with this for now, since it
wouldn't be called; then we avoid the complexity of multiple _backend_api.c
implementations. Then in the future, we can figure out either a compile-time
`#define` or another way to avoid linking in the
TVMBackendRegisterSystemLibSymbol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
