stoa commented on pull request #7742: URL: https://github.com/apache/tvm/pull/7742#issuecomment-823447885
@areusch Hello Andrew Now back to your main comment. There are indeed the board/X-Cube project specific files. They are in apps/stm32/ project directory, which is the X-Cube derived directory. Are you thinking of another place or renaming and adding the STM X-Cube to the name ? There are also a few .py files in the python/tvm/contrib/stm32 directory that allow connecting to STM32 via the ST Link, which indeed use the pyserial package. I thought this functionality is generic enough and interesting enough for the STM32 users to put it together with the code emitter. If you feel these files belong to the X-Cube project, I can move them to the apps/stm32 or whichever place you'd suggest. > here I think I see tests (in tests/micro) for the logic in python/tvm/contrib/stm32 and some of src/runtime/stm32 > right now our test strategy for TVM CI is to test only with virtualization (e.g. qemu or other emulators) on publicly available cloud hardware. so i think it would be hard to test logic such as the usb validation driver inside the TVM CI. This micro/stm32 test verifies only the stm32/code emitter and the runtime/stm32,. It does not test the STLink or X-Cube project logic - no board necessary. It runs in the x86 standard environment. > finally, I should say that out of necessity we do have some of this with microTVM (some RPC layers and pyserial code), but these are effectively ports of the official TVM RPC protocol and we test as much as possible against a virtual e.g. QEMU as well as have a defined path to testing with real hardware. what i don't know is whether e.g. the board-specific logic lives in another repo--if so, i wonder whether it would be easier to test that code in that repository. There is no problem to moving the ST-Link logic to the X-Cube project apps/stm32 directory. The application there is not run with the CI tests because a board would be necessary, this application is there as a demo for STM32 developers on how to use TVM with the HW board. So, I would follow your lead here - please suggest how I could re-arrange the apps/stm32 and contrib/stm32 files to be more in line with the micro. Arthur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
