jwfromm commented on a change in pull request #7823:
URL: https://github.com/apache/tvm/pull/7823#discussion_r617007550
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -182,25 +188,21 @@ def compile_model(
Returns
-------
- graph : str
- A JSON-serialized TVM execution graph.
- lib : tvm.module.Module
- A TVM module containing the compiled functions.
- params : dict
- The parameters (weights) for the TVM module.
- dumps : dict
- Dictionary containing the dumps specified.
+ compiled_model : TVMCPackage
+ The compiled TVMCModel ready to be run.
"""
- dump_code = [x.strip() for x in dump_code.split(",")] if dump_code else
None
+ mod, params = tvmc_model.mod, tvmc_model.params
+
config = {}
- if alter_layout:
- mod = common.convert_graph_layout(mod, alter_layout)
+ if desired_layout:
+ mod = common.convert_graph_layout(mod, desired_layout)
tvm_target, extra_targets = common.target_from_cli(target)
target_host = tvm_target if not target_host else target_host
- tvm_target, target_host = Target.check_and_update_host_consist(tvm_target,
target_host)
+ if target_host is not None:
Review comment:
This is very interesting. The line above `target_host = tvm_target if
not target_host else target_host` doesn't actually exist. If you examine the
source branch it's been removed. I have no idea why github is showing it as
still being here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
