elvin-nnov commented on a change in pull request #7903:
URL: https://github.com/apache/tvm/pull/7903#discussion_r619129976



##########
File path: src/runtime/graph_executor/debug/graph_executor_debug.cc
##########
@@ -282,17 +324,17 @@ class GraphExecutorDebug : public GraphExecutor {
 PackedFunc GraphExecutorDebug::GetFunction(const std::string& name,
                                            const ObjectPtr<Object>& 
sptr_to_self) {
   // return member functions during query.
-  if (name == "get_output_by_layer") {
+  if (name == "debug_get_node_output") {
     return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) {
-      *rv = this->GetOutputByLayer(args[0], args[1]);
+      *rv = this->DebugGetNodeOutput(args[0]);
     });
-  } else if (name == "debug_get_output") {

Review comment:
       if we delete `debug_get_output`, we need to care about this place as 
well 
https://github.com/apache/tvm/blob/main/jvm/core/src/main/java/org/apache/tvm/contrib/GraphModule.java#L52




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to