leandron commented on a change in pull request #7922:
URL: https://github.com/apache/tvm/pull/7922#discussion_r620106210
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -271,7 +277,7 @@ def save_module(module_path, graph, lib, params,
cross=None):
The parameters (weights) for the TVM module.
cross : str or callable object, optional
Function that performs the actual compilation
-
+ cross_options : sst of cross compilation options
Review comment:
Modifying it to comply with Numpy docstring format.
```suggestion
cross_options : str, optional
Command line options to be passed to the cross compiler.
```
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -283,7 +289,7 @@ def save_module(module_path, graph, lib, params,
cross=None):
lib.export_library(path_lib)
else:
logger.debug("exporting library to %s , using cross compiler %s",
path_lib, cross)
- lib.export_library(path_lib, cc.cross_compiler(cross))
+ lib.export_library(path_lib, cc.cross_compiler(cross,
options=cross_options.split(' ')))
Review comment:
Maybe it makes sense to add the command line options to the debug
message on the line above?
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -253,7 +258,8 @@ def compile_model(
return graph_module.get_json(), graph_module.get_lib(),
graph_module.get_params(), dumps
-def save_module(module_path, graph, lib, params, cross=None):
+def save_module(module_path, graph, lib, params, cross=None,
+ cross_options=None):
Review comment:
```suggestion
def save_module(module_path, graph, lib, params, cross=None,
cross_options=None):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
