areusch commented on pull request #7918:
URL: https://github.com/apache/tvm/pull/7918#issuecomment-827106711
@tqchen the practical ramifications of this are that if somehow CUDA module
had code to `GetFunction("foo", query_imports=true)` and `dso0` defined that
function, the module might behave differently after export -> load, correct?
it's not really valid to write code that expects the import tree to be any
particular way, since export/load will change it. so, it seems like we would
also like some more things (perhaps not in this PR):
1. assert at compile time we don't have two functions of the same name
2. ensure we have a single convention by which generated Module use
GetFunction or TVMBackendGetFuncFromEnv.
does that seem reasonable to you? Just wondering what use cases might crop
up in the future that may trip this, and whether it's worth adding asserts in
Import to fix them before export is involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
