areusch commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-828660869
@giuseros i agree it wouldn't affect tuning logs, but we may need to keep `executor=` around for a long time if we add it to `relay.build`. > Also, in general, why adding something to the target if we know we want to remove it entirely (and when it is so straightforward to express as a relay.build parameter)? the problem in my mind is the precedent. here are some more things that could be relay.build parameters: - `--link-params` - `--runtime` - parameters from @Mousius 's recent [RFC](https://discuss.tvm.apache.org/t/rfc-utvm-aot-optimisations-for-embedded-targets/9849) if we add all of these as a top-level API, it's going to get difficult to manage. see my pushback on [PR 7823](https://github.com/apache/tvm/pull/7823). I'd rather continue with the single dirty namespace we have now (Target) rather than dirtying two. I'm not sure I see a direct effect on `tvmc` with this decision--it will complicate things in the short term, but it could still accept `--executor` as a standalone argument, and modify `--target` as needed until the new `compiler_opts` kwarg is merged (presuming we go that route). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
