tqchen edited a comment on pull request #7952:
URL: https://github.com/apache/tvm/pull/7952#issuecomment-830364732


   Thank you @zackcquic ! Looks like a good addition, do you mind also create 
an RFC discussion post? 
   
   I agree it is important to have pass instrumentations, would be good to know 
how can it interact with Trace, since some of the callbacks might be similar 
and we need to unify the interface.  On the design side, I think the runtime 
profiling and pass instrumentation might be different enough that might worth 
two separate solutions(perhaps a bit of reuse of timer if needed) As the former 
have more complexity wrt to GPU timer etc, while the later allows more 
statistics to be collected
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to