manupa-arm commented on a change in pull request #7938:
URL: https://github.com/apache/tvm/pull/7938#discussion_r626736200



##########
File path: src/relay/backend/graph_executor_codegen.cc
##########
@@ -551,10 +713,14 @@ class GraphExecutorCodegen : public 
backend::MemoizedExprTranslator<std::vector<
   Map<Expr, Array<IntegerArray>> storage_device_map_;
   /*! \brief lowered funcs */
   std::unordered_map<std::string, IRModule> lowered_funcs_;
+  /*! \brief lowered funcs */
+  Map<String, FunctionInfo> function_metadata_;
   /*! \brief name map */
   std::unordered_map<std::string, size_t> name_map_;
   /*! \brief compile engine */
   CompileEngine compile_engine_;
+  /*! \brief main function name */
+  const String kMainFuncStr = "main_func";

Review comment:
       I've had a discussion with @giuseros . So the AoT currently uses 
_tvm_<mod_name>_run_func for the main function.
   Few options, we can consider :
   
   A1 : run_func
   A2 : main_func
   A3 : \_tvm\_<mod_name>_run_func ( + all operators function names as well for 
consistency)
   A4 : \_tvm\_<mod_name>_main_func ( + all operators function names as well 
for consistency)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to