apeskov commented on pull request #7875: URL: https://github.com/apache/tvm/pull/7875#issuecomment-833513287
Thank you @tqchen for comment! Your concerns about license mixing is relevant. And I absolutely agree that keep license clean is a priority. I've got your point about reverse linker->tvm dependency. And moreover It will be more elegant solution I guess. I will do it on iOS RPC server side via "tvm.rpc.server.load_module" rewriting. It will have the same effect. But anyway, I didn't fully catch your position regarding keep this module in 3rdparty folder. Is it acceptable or not? My wishes is very simple, I would like to have TVM tuning with iOS devices out of box. Doesn't matter how it will be distributed: integrated submodule, checked out by cmake or installed from brew. If we would like to keep 3rdparty folder only for Apache/MIT/BSD licensed code, I can suggest next plan of integration: 1. Move all changes into iOS RPC server app. New DSO loader injection via "tvm.rpc.server.load_module" modification. 2. Implement minimal loader version from scratch and put it under ALv2 license near iOS_rpc app. Just a minimal quasi loader suitable for tuning purposes. It will depend only on system header files from public SDK (like `mach-o/loader.h` and may be some others). I hope it's applicable to include files with Apple License header from apache code. @tqchen What do you think regarding this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
