manupa-arm commented on a change in pull request #7938:
URL: https://github.com/apache/tvm/pull/7938#discussion_r627614016
##########
File path: python/tvm/micro/model_library_format.py
##########
@@ -27,6 +27,8 @@
from ..relay.backend import executor_factory
from ..relay import param_dict
+MAIN_FUNC_NAME_STR = "run"
Review comment:
Yes, we ll be updating the name to whatever gets agreed in the RFC for
AoT case. I think this is not exactly the run function in second thoughts even
in the AoT case. The actual run function is wrapping the the main function.
Agree with establishing the connection.
For non-AoT case, this should be a name indicating relay "main" function.
How about just "main" ? I still feel mod_name is parent namespace of functions
(including this and operators)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
