giuseros commented on a change in pull request #7988:
URL: https://github.com/apache/tvm/pull/7988#discussion_r627615180
##########
File path: src/target/source/codegen_c.cc
##########
@@ -662,6 +662,11 @@ void CodeGenC::VisitExpr_(const CallNode* op,
std::ostream& os) { // NOLINT(*)
os << " != ";
this->PrintExpr(op->args[0], os);
os << ")";
+ } else if (op->op.same_as(builtin::lookup_param())) {
+ ICHECK_EQ(op->args.size(), 1);
+ const StringImmNode* str = op->args[0].as<StringImmNode>();
+ ICHECK(str != nullptr);
+ os << "__tvm_param__" << str->value;
Review comment:
Maybe I get your point, let me try to rephrase to see if I understood :)
So you are saying, right now, the user could not specify `--link-params` and
she will provide a `lookup_linkparams` function to supply the parameters, and
that will work also in e.g., RPC
With this change it will be more difficult, because if the user does not
specify `--link-params` she will need to provide names directly, which is still
doable in a static compilation scenario, but less doable in a dynamic
environment like RPC
If I understood your point (please, correct if I am wrong), you are asking
if the "dynamic-parameters" is a direction we want to explore. The reply is
"not for now". We don't think this is a priority for now for our embedded work.
So, yes, I would consider this a stand-alone change, only aimed at improving
performance/code size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
