tkonolige commented on a change in pull request #7983:
URL: https://github.com/apache/tvm/pull/7983#discussion_r629533488
##########
File path: include/tvm/runtime/profiling.h
##########
@@ -210,16 +256,19 @@ struct CallFrame {
Timer timer;
/*! Extra performance metrics */
std::unordered_map<std::string, ObjectRef> extra_metrics;
+ /*! User defined metric collectors */
Review comment:
I never do a lookup by key; I just iterate over all the pairs. I could
switch it to a map if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
