csullivan commented on a change in pull request #7980: URL: https://github.com/apache/tvm/pull/7980#discussion_r631280030
########## File path: src/runtime/source_utils.cc ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file source_utils.cc + */ +#include "source_utils.h" + +namespace tvm { +namespace runtime { + +std::unordered_map<std::string, std::string> SplitKernels(std::string source, + std::string delimiter) { + std::unordered_map<std::string, std::string> split_kernels; + if (source.size()) { + size_t begin = source.find(delimiter); Review comment: I noticed you deleted ICHECK here, probably because the error message referred to OpenCL specifically, but there still should be an ``` ICHECK(begin != std::string::npos) ``` on the first search for a kernel delimiter. If none are found, then it is better to catch an error in the code generation early. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
