areusch commented on a change in pull request #8019:
URL: https://github.com/apache/tvm/pull/8019#discussion_r631904664



##########
File path: src/tir/analysis/calculate_workspace.cc
##########
@@ -46,6 +48,10 @@ size_t WorkspaceCalculator::operator()(const PrimFunc& func) 
{
   return this->max_size;
 }
 
+size_t WorkspaceCalculator::GetByteAlignedSize(size_t non_aligned_size) {
+  return ((non_aligned_size + byte_alignment - 1) / byte_alignment) * 
byte_alignment;

Review comment:
       okay sure, but also since this calculator only does Workspace memory, 
what's the plan for when we later fuse graph and workspace memory planning such 
that they could use the same memory pool? it seems like the workspace memory 
alignment should be a property of the function that allocates it, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to