masahi commented on pull request #8048:
URL: https://github.com/apache/tvm/pull/8048#issuecomment-841481729


   > @masahi In the new `SPIRVSupport` struct, there's a field that will hold 
the subgroup operation support. Can you confirm that this is the appropriate 
parameter you'll need for the prefix sum improvements?
   
   Probably we need more fine-grained information than yes/no result. Vulkan 
has (surprisingly) wide variety of subgroup op support as described in 
https://www.khronos.org/blog/vulkan-subgroup-tutorial. For prefix scan, it is 
probably enough to have `GL_KHR_shader_subgroup_arithmetic`, since it literally 
has `subgroupExclusiveAdd`. I'm also planning to do FFT at some point, for that 
I probably want explicit shuffle ops as provided by 
`GL_KHR_shader_subgroup_shuffle` extension.
   
   Since this is a complicated issue, we can add support for them on a need 
basis later. So feel free to drop `supported_subgroup_operations` from this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to