merrymercy edited a comment on pull request #7767: URL: https://github.com/apache/tvm/pull/7767#issuecomment-841482525
I went throught the new tutorials and think it is much better than our old tutorials. Thanks for your effrot! But I also found some small bugs. Could you fix them? 1. Some hyperlinks are broken. For example, the link in this line https://github.com/apache/tvm/blob/3bf65b7753e92b49cb736b20151c32fd33f5f52f/tutorials/get_started/tune_matmul_x86.py#L26 is broken, because the destination `autotvm_matmul` is deleted by you in your new tutorials. IIRC, when you build the docs, you should see these warnings. 2. This line is wrong https://github.com/apache/tvm/blob/3bf65b7753e92b49cb736b20151c32fd33f5f52f/tutorials/get_started/tensor_expr_get_started.py#L325 3. This introduction figure (https://tvm.apache.org/docs/tutorials/get_started/introduction.html#an-overview-of-tvm-and-model-optimization) can be improved. <img width="1163" alt="image" src="https://user-images.githubusercontent.com/15100009/118326750-420d0b80-b4ba-11eb-9ea5-589629b0406e.png"> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
