leandron commented on a change in pull request #8094:
URL: https://github.com/apache/tvm/pull/8094#discussion_r636323804
##########
File path: tests/python/contrib/test_verilator/test_mobilenet.py
##########
@@ -220,6 +221,8 @@ def tmobilenet(lanes):
lanes : Int
The number of vector lanes.
"""
+ if skip_test():
Review comment:
One small note about this approach, when compared to the `skipIf` is
that if you have no Verilator and you run these tests, once you reach the
`return`, you'll see `PASSED` in the report, which might give the illusion that
the test ran and passed.
The `skipIf` will be a bit more precise and report `SKIPPED`, so it is clear
that the test was not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
