Lunderberg commented on pull request #8109: URL: https://github.com/apache/tvm/pull/8109#issuecomment-846277348
Looks good to me, and I agree on using 1 as the default `thread_warp_size`. Both the [`VkPhysicalDeviceSubgroupProperties`](https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkPhysicalDeviceSubgroupProperties.html) and the [`VkPhysicalDeviceSubgroupSizeControlPropertiesEXT`](https://khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkPhysicalDeviceSubgroupSizeControlPropertiesEXT.html) documentation give a minimum subgroup size of 1, so the spec doesn't give us any further guarantees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
