electriclilies commented on pull request #8126: URL: https://github.com/apache/tvm/pull/8126#issuecomment-852319547
I think the repetition of the word quantize is in `quantize_fake_quantization` is confusing -- maybe you could avoid using the word quantize as a verb and name it something like `fake_quantize_to_int8`? That doesn't have an active verb in it at all, though, which is also sub-optimal. And, if this gets expanded to other dtypes you'd need to change the name.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
