mbrookhart commented on a change in pull request #8165:
URL: https://github.com/apache/tvm/pull/8165#discussion_r643536633
##########
File path: python/tvm/relay/op/transform.py
##########
@@ -917,7 +922,7 @@ def strided_slice(data, begin, end, strides=None,
slice_mode="end"):
begin = _make.where(begin < cast_like(const(0), begin), begin +
ishape_slice, begin)
begin = _make.where(begin >= ishape_slice, ishape_slice, begin)
return _dyn_make.strided_slice(data, begin, end, strides, slice_mode)
Review comment:
Perhaps we should throw an error if we hit this codepath and axes is
defined? With a TODO for extending axes to the dynamic case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
