areusch commented on a change in pull request #8144:
URL: https://github.com/apache/tvm/pull/8144#discussion_r644147330
##########
File path: docker/bash.sh
##########
@@ -46,6 +46,16 @@ if [[ "$1" == "--net=host" ]]; then
shift 1
fi
+# Mount external directory to the docker
+CI_DOCKER_MOUNT_DIR=( )
+CI_DOCKER_MOUNT_CMD=""
+if [[ "$1" == "--mount" ]]; then
+ shift 1
+ CI_DOCKER_MOUNT_DIR+="$1"
+ shift 1
+ CI_DOCKER_MOUNT_CMD="--mount
type=bind,source=${CI_DOCKER_MOUNT_DIR},target=${CI_DOCKER_MOUNT_DIR}"
Review comment:
i think we should maintain one convention for this file. since we are
bind-mounting, it's probably fine to just keep using `-v`. but if you want to
change the others for readability, you can too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
