csullivan commented on a change in pull request #8110:
URL: https://github.com/apache/tvm/pull/8110#discussion_r646943807
##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -770,7 +770,8 @@ class CompileEngineImpl : public CompileEngineNode {
With<PassContext> fresh_pass_ctx_scope(PassContext::Create());
std::unordered_map<te::Tensor, tir::Buffer> binds;
- cache_node->funcs = tvm::lower(cfunc->schedule, all_args,
cache_node->func_name, binds);
+ cache_node->funcs =
+ tvm::LowerSchedule(cfunc->schedule, all_args, cache_node->func_name,
binds);
Review comment:
We shouldn't need to route through the `relay.backend.lower` packed
function any longer right? I'd suggest either removing it and the above
conditional (line 766) or also reproducing its functionality in c++ if we do
need it as part of this PR. This way we avoid an unnecessary round trip through
python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
