junrushao1994 commented on a change in pull request #8215:
URL: https://github.com/apache/tvm/pull/8215#discussion_r649324189



##########
File path: python/tvm/script/intrin.py
##########
@@ -180,6 +185,11 @@ def opaque_axis(begin, end, span):
     return get_axis(begin, end, "opaque", span)
 
 
+@register
+def Select(cond, if_body, else_body, span):  # pylint: disable=invalid-name

Review comment:
       I think we should stick with lower cases “tir.select”, given uncased 
ones are used as a convention (so far) in tvm script.
   
   On the other hand, we should think about addressing pylint complaints about 
undefined functions and mismatched arguments more systematically




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to