giuseros edited a comment on pull request #8096: URL: https://github.com/apache/tvm/pull/8096#issuecomment-860715052
Hi @areusch , After some thinking we came up with a different solution. The way we are doing things now is the following: pass-a) Compose the `main_func` with `tvm_set_struct`, i.e., codegen ready pass-b) Storage rewrite modified to take care of the structs pass-c) `tvm::build` A possible alternative can be the following: pass-a2) Compose the `main_func` without `tvm_set_struct`. This means that the packed calls will receive raw pointers. This in turn means that the `main_func` in TIR is not ready to be code generated pass-b2) Storage rewrite without any change. This is possible now since we are not using `tvm_set_struct` yet pass-c2) transform the packed calls inputs by using `tvm_set_struct`. We can actually avoid this pass if we are using unpacked signatures. pass-d2) `tvm::build` With pipilene-2 we can leave `StorageRewrite` unchanged and still address the issues that `tvm_set_struct` gives us. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
