leandron commented on a change in pull request #8253:
URL: https://github.com/apache/tvm/pull/8253#discussion_r651587235
##########
File path: tests/python/driver/tvmc/test_tvmc_common.py
##########
@@ -306,3 +306,49 @@ def test_parse_quotes_and_separators_on_options():
assert len(targets_double_quote) == 1
assert "+v1.0x,+value" == targets_double_quote[0]["opts"]["option1"]
+
+
+def test_config_invalid_format():
+ with pytest.raises(TVMCException):
+ _ =
tvmc.common.parse_configs(["relay.backend.use_auto_scheduler.missing.value"])
+
+
+def test_config_missing_from_tvm():
+ with pytest.raises(TVMCException):
+ _ =
tvmc.common.parse_configs(["relay.backend.use_auto_scheduler.missing.value=1234"])
+
+
+def test_config_unsupported_tvmc_config():
+ with pytest.raises(TVMCException):
+ _ = tvmc.common.parse_configs(["tir.LoopPartition=value"])
+
+
+def test_config_empty():
+ with pytest.raises(TVMCException):
+ _ = tvmc.common.parse_configs([""])
+
+
+def test_config_valid_config_bool():
+ configs =
tvmc.common.parse_configs(["relay.backend.use_auto_scheduler=true"])
+
+ assert len(configs) == 1
+ assert "relay.backend.use_auto_scheduler" in configs.keys()
+ assert configs["relay.backend.use_auto_scheduler"] == True
+
+
+def test_config_valid_multiple_configs():
+ configs = tvmc.common.parse_configs(
+ [
+ "relay.backend.use_auto_scheduler=false",
+ "tir.detect_global_barrier=10",
+ "relay.ext.vitis_ai.options.build_dir=mystring",
Review comment:
Yeah, it crashed because that specific CI environment doesn't build with
Vitis support ON. I'll need to use a different config name for my test.
edit: Actually, it turns out that vitis configs are the only ones using
string type at the moment, so I make this specific test case to be conditional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
